Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Fix type_complexity warning in components/script/dom #33835

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

taniishkaaa
Copy link
Contributor

Fixes type_complexity warning in components/script/dom/bluetoothdevice.rs as a part of #31500


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are a part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they do not modify functionality

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable cleanup! Thanks!

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed that the changes made a documentation comment move further away from the code is was related to.

@taniishkaaa
Copy link
Contributor Author

Sorry, just noticed that the changes made a documentation comment move further away from the code is was related to.

updated 👍

@taniishkaaa taniishkaaa requested a review from jdm October 15, 2024 04:24
@jdm jdm enabled auto-merge October 15, 2024 04:31
auto-merge was automatically disabled October 15, 2024 06:34

Head branch was pushed to by a user without write access

Copy link
Member

@mukilan mukilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mukilan mukilan added this pull request to the merge queue Oct 15, 2024
Merged via the queue into servo:main with commit c37fb2e Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants