Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix let binding in components/fonts/font_context.rs #33643

Merged
merged 2 commits into from
Oct 4, 2024
Merged

clippy: Fix let binding in components/fonts/font_context.rs #33643

merged 2 commits into from
Oct 4, 2024

Conversation

cashall-0
Copy link
Contributor

Removed the variable declaration because the return value of function can be returned directly as adviced in let_and_return

  • There are tests for these changes OR
  • These changes do not require tests because ___

@cashall-0 cashall-0 requested a review from gterzian as a code owner October 3, 2024 20:54
mukilan
mukilan approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mukilan mukilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mukilan mukilan enabled auto-merge October 4, 2024 05:09
@mukilan mukilan added this pull request to the merge queue Oct 4, 2024
Merged via the queue into servo:main with commit f55e777 Oct 4, 2024
14 checks passed
@cashall-0
Copy link
Contributor Author

@mukilan should I do more commits to this branch or use new branches for new fixes?

taniishkaaa pushed a commit to taniishkaaa/servo that referenced this pull request Oct 4, 2024
@cashall-0 @taniishkaaa
clippy: Fix let binding in components/fonts/font_context.rs (servo#33643
cdc249a 
)

* clippy: Fix let binding in components/fonts/font_context.rs

Signed-off-by: PS Adavize <[email protected]>

* clippy: Fix needless borrow in components\script\dom\gpucanvascontext.rs

Signed-off-by: PS Adavize <[email protected]>

---------

Signed-off-by: PS Adavize <[email protected]>
Taym95 pushed a commit to Taym95/servo that referenced this pull request Oct 8, 2024
@cashall-0 @Taym95
clippy: Fix let binding in components/fonts/font_context.rs (servo#33643
a5d9389 
)

* clippy: Fix let binding in components/fonts/font_context.rs

Signed-off-by: PS Adavize <[email protected]>

* clippy: Fix needless borrow in components\script\dom\gpucanvascontext.rs

Signed-off-by: PS Adavize <[email protected]>

---------

Signed-off-by: PS Adavize <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukilan mukilan mukilan approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix as many clippy problems as possible
2 participants
@cashall-0 @mukilan