Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forced inclusion of aws-lc-rs causes linker errors #2010

Closed
Diggsey opened this issue Jun 18, 2024 · 4 comments
Closed

Forced inclusion of aws-lc-rs causes linker errors #2010

Diggsey opened this issue Jun 18, 2024 · 4 comments

Comments

@Diggsey
Copy link

Diggsey commented Jun 18, 2024

With aws-lc-rs enabled by a default feature and therefore impossible to disable without forking all intermediate crates, there is no way to remove it form the crate graph.

Including it causes linker errors due to erroneously exported symbols:

aws/aws-lc-rs#446

This breaks all downstream crates of rustls which use boring-sys.
@ctz
Copy link
Member

ctz commented Jun 18, 2024

What action are you expecting rustls to do here?

@Diggsey
Copy link
Author

Diggsey commented Jun 18, 2024

Remove aws-lc-rs as a default feature until it's no longer broken.

@ctz
Copy link
Member

ctz commented Jun 18, 2024

I don't think that is proportionate or reasonable.

Especially as the issue is equally boring-sys's problem (it is not a bona-fide -sys crate -- it builds and includes the boringssl code itself). It takes two crates to fail to prefix all their symbols for this issue to occur (see, eg, cloudflare/boring#197 ).

Going to close this.

@ctz ctz closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
@Diggsey

This comment has been minimized.

Sign in to view
@rustls rustls locked as too heated and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Diggsey @ctz