Skip to content

Latest commit

 

History

History
100 lines (75 loc) · 6.2 KB

2024-11-11.md

File metadata and controls

100 lines (75 loc) · 6.2 KB

2024-11-11 Triage Log

Regressions primarily in doc builds. No significant changes in cycle or max-rss counts.

Triage done by @simulacrum. Revision range: 27e38f8f..d4822c2d

Summary:

(instructions:u) mean range count
Regressions ❌
(primary)
0.5% [0.2%, 1.0%] 61
Regressions ❌
(secondary)
0.9% [0.2%, 1.5%] 30
Improvements ✅
(primary)
-2.9% [-5.0%, -0.6%] 7
Improvements ✅
(secondary)
-1.5% [-5.0%, -0.2%] 28
All ❌✅ (primary) 0.1% [-5.0%, 1.0%] 68

1 Regressions, 1 Improvements, 4 Mixed; 1 of them in rollups 47 artifact comparisons made in total

Regressions

Clean middle generics using paren sugar if trait has #[rustc_paren_sugar] #132697 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)
0.2% [0.1%, 0.4%] 8
Regressions ❌
(secondary)
0.3% [0.2%, 0.4%] 16
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.1%, 0.4%] 8

Doc-only regressions, no fix directly planned (prioritizing code clarity), but inspired some unrelated cleanup in rust-lang/rust#132886.

rustdoc-search: simplify rules for generics and type params #127589 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)
0.2% [0.1%, 0.5%] 15
Regressions ❌
(secondary)
0.4% [0.1%, 0.5%] 19
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 0.2% [0.1%, 0.5%] 15

Doc-only regressions, likely genuine given the change.

Improvements

Only disable cache if predicate has opaques within it #132625 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-5.0%, -0.2%] 7
Improvements ✅
(secondary)
-3.0% [-5.1%, -0.3%] 10
All ❌✅ (primary) -2.7% [-5.0%, -0.2%] 7

Mixed

Add new unstable feature const_eq_ignore_ascii_case #131721 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.7%, -0.1%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-0.7%, 0.2%] 5

Probably mostly luck of some kind, change itself is library-only.

Emit warning when calling/declaring functions with unavailable vectors. #132173 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)
0.5% [0.2%, 1.0%] 36
Regressions ❌
(secondary)
0.6% [0.2%, 0.9%] 6
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) 0.5% [-0.4%, 1.0%] 37

Regression, but a bunch of optimization work already went into it (see rust-lang/rust#132173 (comment)).

Rollup of 6 pull requests #132831 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.3%, 1.5%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-1.4%, -0.2%] 13
All ❌✅ (primary) - - 0

Queued up one trial build. Likely a real regression, but not necessarily worth digging deeper given limited impact (few benchmarks).