Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "gnu" in the target env for FreeBSD armv6/7 #132764

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Drop "gnu" in the target env for FreeBSD armv6/7 #132764

merged 1 commit into from
Nov 9, 2024

Conversation

MikaelUrankar
Copy link
Contributor

FreeBSD is not a GNU system

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@workingjubilee
Copy link
Member

ironically, you are the one who added the "gnueabihf" in the first place: adddee4

I take it that you are satisfied now with the target_abi string.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 8, 2024

📌 Commit f7580c6 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2024
@jieyouxu jieyouxu assigned workingjubilee and unassigned pnkfelix Nov 8, 2024
@jieyouxu jieyouxu added the O-freebsd Operating system: FreeBSD label Nov 8, 2024
@MikaelUrankar
Copy link
Contributor Author

ironically, you are the one who added the "gnueabihf" in the first place: adddee4

I take it that you are satisfied now with the target_abi string.

@bors r+ rollup

I thought it had to match the target triple.

@workingjubilee
Copy link
Member

workingjubilee commented Nov 8, 2024 •
edited
Loading

Aha!

Perfectly understandable. Yes, there's actually secretly no relationship... having a significant deviance is unusual, but this isn't all that significant.

@bors
Copy link
Contributor

bors commented Nov 8, 2024

⌛ Testing commit f7580c6 with merge 328b759...

@bors
Copy link
Contributor

bors commented Nov 9, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 328b759 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2024
@bors bors merged commit 328b759 into rust-lang:master Nov 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 9, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (328b759): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.5% [1.5%, 1.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.5% [-3.8%, -3.2%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.98s -> 780.614s (0.08%)
Artifact size: 335.38 MiB -> 335.33 MiB (-0.01%)

mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
@bors @mati865
Auto merge of rust-lang#132764 - MikaelUrankar:freebsd_armv7, r=worki…
29db6da 
…ngjubilee

Drop "gnu" in the target env for FreeBSD armv6/7

FreeBSD is not a GNU system
@madsmtm madsmtm mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees

@workingjubilee workingjubilee

Labels
merged-by-bors This PR was explicitly merged by bors. O-freebsd Operating system: FreeBSD S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
8 participants
@MikaelUrankar @rustbot @workingjubilee @bors @rust-timer @asomers @pnkfelix @jieyouxu