-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forget
reports that files have been deleted when they can't be
#5140
Comments
4 tasks
@konidev20 Thanks! Not sure I'm going to be able to test right away. Any chance you could add tests? This is required for the MR to be merged anyway. |
Hey @colans, I have started to add a few tests, will complete it over the next weekend. |
I have added the tests. Seems to be working fine. Please check it out in your free time @colans |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Output of
restic version
restic 0.17.0 compiled with go1.23rc2 on linux/amd64
What backend/service did you use to store the repository?
BackUpscale
Problem description / Steps to reproduce
When running in append-only mode, snapshots can't be deleted. However,
restic forget
reports that they have been, even though they haven't.Expected behavior
Shouldn't the last line here say that "0 / 1" files have been deleted?
Actual behavior
Instead, the last line says, "1 / 1 files deleted". So why it saying something was deleted when it wasn't? Earlier in the output it says "Forbidden" and the snapshot is still there. This is a UX hit because users will think that it's actually happening, when it can't be. And then we all start getting more support requests. :)
Do you have any idea what may have caused this?
My guess is that it's reporting that number of things that are supposed to be deleted as per the user request, not the number of things that actually have been deleted after the request has been processed.
Did restic help you today? Did it make you happy in any way?
If it weren't for Restic, I wouldn't be able to work on BackUpScale! So thank you all!!
The text was updated successfully, but these errors were encountered: