Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to reflect API changes #2433

Open
TheJanzap opened this issue Aug 8, 2024 · 2 comments · May be fixed by #2439
Open

Update documentation to reflect API changes #2433

TheJanzap opened this issue Aug 8, 2024 · 2 comments · May be fixed by #2439

Comments

@TheJanzap
Copy link

Similar to #2187, the Wiki also contains outdated code: The Threading page is still using PythonEngine.ImportModule().

There might be other pages that are outdated, like Loading Python file in .NET and Call function where Py.GIL() is not inside a using. I'm unsure if this is still correct.

I've also seen various code snippets where the new Runtime.DLL requirement is absent, most notably in the README and the documentation.
@filmor
Copy link
Member

filmor commented Aug 8, 2024

PRs are welcome. And the Wiki is open for changes anyway. If it is too wrong, we'll have to drop it.

@TheJanzap TheJanzap linked a pull request Aug 22, 2024 that will close this issue
Open
5 tasks
@TheJanzap
Copy link
Author

Updated everything I've mentioned, except the use of Py.GIL() on the wiki page. I don't know enough about the Pythonnet code base to give a definitive answer wheter the code there could be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentation to reflect API changes TheJanzap/pythonnet
2 participants
@filmor @TheJanzap