Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all low-level interfaces internal #1167

Closed
filmor opened this issue Jun 19, 2020 · 2 comments
Closed

Make all low-level interfaces internal #1167

filmor opened this issue Jun 19, 2020 · 2 comments

Comments

@filmor
Copy link
Member

filmor commented Jun 19, 2020

In particular, we should not expose the Runtime class. All functionality that is of use outside of the implementation of Python.NET itself should instead be moved to separate (public) classes.
@filmor filmor mentioned this issue Jun 19, 2020
Merged
4 tasks
@bmiller-pm
Copy link

Actually as an embedder, I'd love/need to have the Runtime internals exposed.
So much so I had to build python.net myself and add the 'friend' attribute:
[assembly: InternalsVisibleTo("my assembly")]

I see the need for embedding python over the need to import the clr in python.
Maybe there should be a target/build for embedding?

@lostmsu
Copy link
Member

lostmsu commented Sep 2, 2020

@QuickWire although it might be advantageous to have direct access to C routines, Python.NET provides a higher-level product. Because of that, we should hide the implementation details as much as possible to be able to change it later at any moment. Also see my comment on your thread state issue.

@filmor filmor closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@filmor @lostmsu @bmiller-pm