Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-57539: Increase calendar test coverage #93468

Merged
merged 4 commits into from
Jun 7, 2022
Merged

gh-57539: Increase calendar test coverage #93468

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c70a408
gh-57539: Increase calendar coverage
hugovk Jun 3, 2022
5288325
Skip test if locale not available
hugovk Jun 3, 2022
646c782
Update Misc/NEWS.d/next/Tests/2022-06-03-16-26-04.gh-issue-57539.HxWg…
hugovk Jun 4, 2022
1952568
Remove spurious comment and a spurious space
ambv Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/test/test_calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,20 @@ def test_locale_calendars(self):
new_october = calendar.TextCalendar().formatmonthname(2010, 10, 10)
self.assertEqual(old_october, new_october)

def test_locale_calendar_formatweekday(self):
try:
# formatweekday uses different day names based on the available width.
cal = calendar.LocaleTextCalendar(locale='en_US')
# For short widths, a centered, abbreviated name is used.
self.assertEqual(cal.formatweekday(0, 5), " Mon ")
# For really short widths, even the abbreviated name is truncated.
self.assertEqual(cal.formatweekday(0, 2), "Mo")
# For long widths, the full day name is used.
self.assertEqual(cal.formatweekday(0, 10), " Monday ")
except locale.Error:
# cannot set the en_US locale -- skip test
raise unittest.SkipTest('cannot set the en_US locale')
ambv marked this conversation as resolved.
Show resolved Hide resolved

def test_locale_html_calendar_custom_css_class_month_name(self):
try:
cal = calendar.LocaleHTMLCalendar(locale='')
Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ Nils Fischbeck
Frederik Fix
Tom Flanagan
Matt Fleming
Sean Fleming
Hernán Martínez Foffani
Benjamin Fogle
Artem Fokin
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2022-06-03-16-26-04.gh-issue-57539.HxWgYO.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Increase calendar coverage
hugovk marked this conversation as resolved.
Show resolved Hide resolved