Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110590: Fix _sre.compile error overwrite #110591

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 10, 2023

PyLong_AsUnsignedLong strikes back 😉

@erlend-aasland erlend-aasland enabled auto-merge (squash) October 10, 2023 09:32
@erlend-aasland erlend-aasland merged commit 344d3a2 into python:main Oct 10, 2023
22 checks passed
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
…ons (pythonGH-110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2023

GH-110613 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
…ons (pythonGH-110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2023

GH-110614 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 10, 2023
erlend-aasland pushed a commit that referenced this pull request Oct 10, 2023
…ions (GH-110591) (#110614)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
erlend-aasland pushed a commit that referenced this pull request Oct 10, 2023
…ions (GH-110591) (#110613)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ons (python#110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants