Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataclasses.astuple breaks on DefaultDict #98169

Closed
kwsp opened this issue Oct 11, 2022 · 0 comments
Closed

dataclasses.astuple breaks on DefaultDict #98169

kwsp opened this issue Oct 11, 2022 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@kwsp
Copy link
Contributor

kwsp commented Oct 11, 2022 •
edited by bedevere-bot
Loading

Bug report

This is very similar to #79721

from dataclasses import dataclass, astuple
from typing import DefaultDict, List
from collections import defaultdict

@dataclass
class C:
    mp: DefaultDict[str, List]

dd = defaultdict(list)
dd["x"].append(12)
c = C(mp=dd)
d = astuple(c)  # throws "TypeError: first argument must be callable or None"


assert d == ({"x": [12]},)
assert d[0] is not c.mp  # make sure defaultdict is copied

Basically applying the same fix for asdict from #32056 to astuple.

Your environment

  • CPython versions tested on: 3.10.7
  • Operating system and architecture: macOS, arm64

Linked PRs
@kwsp kwsp added the type-bug An unexpected behavior, bug, or error label Oct 11, 2022
kwsp added a commit to kwsp/cpython that referenced this issue Oct 11, 2022
@kwsp
pythongh-98169 dataclasses.astuple support DefaultDict
81d9170
@bedevere-bot bedevere-bot mentioned this issue Oct 11, 2022
Merged
carljm pushed a commit that referenced this issue Mar 13, 2023
@kwsp @eendebakpt
gh-98169 dataclasses.astuple support DefaultDict (#98170)
71e37d9 
Co-authored-by: Pieter Eendebak <[email protected]>
@carljm carljm closed this as completed Mar 13, 2023
carljm added a commit to carljm/cpython that referenced this issue Mar 14, 2023
@carljm
Merge branch 'main' into inlinecomp2
6c5f269 
* main: (50 commits)
  pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685)
  pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661)
  pythongh-102354: change python3 to python in docs examples (python#102696)
  pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506)
  pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684)
  pythongh-100315: clarification to `__slots__` docs. (python#102621)
  pythonGH-100227: cleanup initialization of global interned dict (python#102682)
  doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677)
  pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014)
  pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649)
  pythongh-102627: Replace address pointing toward malicious web page (python#102630)
  pythongh-98831: Use DECREF_INPUTS() more (python#102409)
  pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659)
  pythongh-101524: Fix the ChannelID tp_name (pythongh-102655)
  pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075)
  pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)
  pythongh-102650: Remove duplicate include directives from multiple source files (python#102651)
  pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640)
  pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631)
  ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@kwsp @eendebakpt @Fidget-Spinner
pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)
c54eeaf 
Co-authored-by: Pieter Eendebak <[email protected]>
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@kwsp @eendebakpt @warsaw
pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)
3f86f25 
Co-authored-by: Pieter Eendebak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carljm @kwsp