Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port core types to Argument Clinic #91102

Closed
arhadthedev opened this issue Mar 7, 2022 · 2 comments
Closed

Port core types to Argument Clinic #91102

arhadthedev opened this issue Mar 7, 2022 · 2 comments
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-argument-clinic type-feature A feature request or enhancement

Comments

@arhadthedev
Copy link
Member

BPO 46946
Nosy @arhadthedev
PRs
  • gh-91102: Use Argument Clinic for EncodingMap  #31725
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2022-03-07.14:12:29.924>
labels = ['interpreter-core', 'type-feature', '3.11']
title = 'Port core types to Argument Clinic'
updated_at = <Date 2022-03-07.14:13:12.489>
user = 'https://github.com/arhadthedev'

    bugs.python.org fields:

    activity = <Date 2022-03-07.14:13:12.489>
actor = 'arhadthedev'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2022-03-07.14:12:29.924>
creator = 'arhadthedev'
dependencies = []
files = []
hgrepos = []
issue_num = 46946
keywords = ['patch']
message_count = 1.0
messages = ['414670']
nosy_count = 1.0
nosy_names = ['arhadthedev']
pr_nums = ['31725']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46946'
versions = ['Python 3.11']
    @arhadthedev
    Copy link
    Member Author

    This is done to:

    • update docstrings to current standards enforced by AC
    • get proper naming for arguments of impl-functions (for example, self instead of obj and instance)
    • strip boilerplate reducing current 16k lines of code to something little more manageable
    • get a proper excuse to collapse overbloated PyTypeObject initializers by throwing out zeroes with designated initialization thanks to C99&11 being promoted. For example, EncodingMapType in unicodeobject.c reduced from 43 lines to 8, five times less.

    @arhadthedev arhadthedev added 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Mar 7, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @arhadthedev arhadthedev mentioned this issue Apr 12, 2022
    Merged
    JelleZijlstra added a commit that referenced this issue Apr 18, 2022
    @arhadthedev @JelleZijlstra
    gh-91102: Use Argument Clinic for EncodingMap (#31725)
    2f0fc52 
    Co-authored-by: Jelle Zijlstra <[email protected]>
    @arhadthedev arhadthedev mentioned this issue May 8, 2022
    Closed
    @arhadthedev
    Copy link
    Member Author

    This issue is done. Could somebody close it please? I'm a mannequin here.

    @arhadthedev arhadthedev mentioned this issue May 17, 2022
    Merged
    erlend-aasland added a commit that referenced this issue Jul 20, 2022
    @arhadthedev @erlend-aasland
    gh-91102: Port 8-argument _warnings.warn_explicit to Argument Clinic (#…
    41e0585 
    …92891)

Co-authored-by: Erlend E. Aasland <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-argument-clinic type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    gh-91102: Use Argument Clinic for str_iterator arhadthedev/cpython
    3 participants
    @serhiy-storchaka @arhadthedev @AlexWaygood