examples that are found on a property dont detect the line number

class example(object):
  @property
  def me(self):
   """
   >>> 1/0
   """
   pass

@ronny can you provide a patch for this?

this is my first contribution to Python core so I really have no idea how to do this, but I have found a solution (works in Py3.4, 2.7):

in doctest.py after line 1087 ("lineno = getattr(obj, 'co_firstlineno', None)-1") add these lines:

    if lineno is None and isinstance(obj, property) and \
            obj.fget is not None:
        obj = obj.fget.__code__
        lineno = getattr(obj, 'co_firstlineno', None) 
        # no need for -1 because of decorator. 

I can try to make a patch file for this, but just want to be sure I'm on the right track for contributing first. I know how to do a Git pull, but not hg/patch.

(p.s., I think the current code "lineno = getattr(obj, 'co_firstlineno', None)-1" has an error; if the getattr does not find 'co_firstlineno', it will return None and then subtract 1 from None which is a TypeError).

I took the ideas from @Michael.Cuthbert and wrote a proper test. It's my first patch so I hope everything's fine with it. If not I'm happy for feedback :)

The test looks great to me. Does anyone on nosy know the proper way to request a patch review?

Left a comment on Rietveld. I don't have time right now to check the test, but I suspect you tested it before submitting the patch, so it should probably be fine.

Yes, I've tested it.

looks like we're stuck on a style change (backslash to parens; ironic: I chose backslash to match surrounding code; I never use them myself). tuxtimo - could you fix this? (or I'll do once the move to github is done). Thanks!

Here's a rather obscure bug that I was able to catch before we put this into action: doctests inside the __doc__ for namedtuples (and perhaps all namedtuples?) are instances of property, have .fget, but do not have .fget.__code__. Thus one more check is needed:

    if (lineno is None and 
            isinstance(obj, property) and
            obj.fget is not None and 
            hasattr(obj.fget, '__code__')):
        obj = obj.fget.__code__
        lineno = getattr(obj, 'co_firstlineno', None)

just poking to see if this patch is worth trying to get into 3.7

A pull request has been in for about a month -- is it possible to review or merge or comment? Thanks!

The PR appears to need a better test according to #3419 (comment).

The code I contributed to 3.7 is still, I believe, the best path forward. Based on my experiences trying to contribute to cpython, I will not be continuing on this issue. It can be closed.

The linked PR (#3419) seems to have been closed with no discussion, I'm reopening.

A