Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_sre.compile overwrites TypeError with OverflowError #110590

Closed
sobolevn opened this issue Oct 10, 2023 · 0 comments
Closed

_sre.compile overwrites TypeError with OverflowError #110590

sobolevn opened this issue Oct 10, 2023 · 0 comments
Assignees
@sobolevn
Labels
extension-modules C modules in the Modules dir topic-regex type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Oct 10, 2023 •
edited by bedevere-app bot
Loading

Bug report

Reproduction:

>>> import _sre
>>> _sre.compile('', 0, ['abc'], 0, {}, ())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: regular expression code size limit exceeded

It should be:

>>> import _sre
>>> _sre.compile('', 0, ['abc'], 0, {}, ())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: an integer is required

Because the third arg is code: object(subclass_of='&PyList_Type'), it is assumed to be integers inside.

Problematic lines:

cpython/Modules/_sre/sre.c

Lines 1510 to 1515 in def7ea5

unsigned long value = PyLong_AsUnsignedLong(o);
self->code[i] = (SRE_CODE) value;
if ((unsigned long) self->code[i] != value) {
PyErr_SetString(PyExc_OverflowError,
"regular expression code size limit exceeded");
break;

They do not check for PyLong_AsUnsignedLong errors.
I have a PR ready :)

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir labels Oct 10, 2023
@sobolevn sobolevn self-assigned this Oct 10, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 10, 2023
@sobolevn
pythongh-110590: Fix _sre.compile error overwrite
c829171
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2023
Merged
erlend-aasland pushed a commit that referenced this issue Oct 10, 2023
@sobolevn
gh-110590: Fix a bug where _sre.compile would overwrite exceptions (#…
344d3a2 
…110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 10, 2023
@sobolevn @miss-islington
pythongh-110590: Fix a bug where _sre.compile would overwrite excepti…
7ab8b37 
…ons (pythonGH-110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 10, 2023
@sobolevn @miss-islington
pythongh-110590: Fix a bug where _sre.compile would overwrite excepti…
530247b 
…ons (pythonGH-110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
This was referenced Oct 10, 2023
Merged
Merged
erlend-aasland pushed a commit that referenced this issue Oct 10, 2023
@miss-islington @sobolevn
[3.11] gh-110590: Fix a bug where _sre.compile would overwrite except…
7fefed0 
…ions (GH-110591) (#110614)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
erlend-aasland pushed a commit that referenced this issue Oct 10, 2023
@miss-islington @sobolevn
[3.12] gh-110590: Fix a bug where _sre.compile would overwrite except…
c1e8e90 
…ions (GH-110591) (#110613)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
(cherry picked from commit 344d3a2)

Co-authored-by: Nikita Sobolev <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@sobolevn @Glyphack
pythongh-110590: Fix a bug where _sre.compile would overwrite excepti…
7e68d49 
…ons (python#110591)

TypeError would be overwritten by OverflowError
if 'code' param contained non-ints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
extension-modules C modules in the Modules dir topic-regex type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @AlexWaygood