Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling bugs in ast.c #104482

Closed
iritkatriel opened this issue May 14, 2023 · 0 comments · Fixed by #104483
Closed

Error handling bugs in ast.c #104482

iritkatriel opened this issue May 14, 2023 · 0 comments · Fixed by #104483
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@iritkatriel
Copy link
Member

iritkatriel commented May 14, 2023 •
edited by bedevere-bot
Loading

in validate_pattern, there are two places where in case of error we break out of a loop, but we also need to break out of the switch.

--- a/Python/ast.c
+++ b/Python/ast.c
@@ -580,7 +580,9 @@ validate_pattern(struct validator *state, pattern_ty p, int star_ok)
                     break;
                 }
             }
-
+            if (ret == 0) {
+                break;
+            }
             ret = validate_patterns(state, p->v.MatchMapping.patterns, /*star_ok=*/0);
             break;
         case MatchClass_kind:
@@ -620,6 +622,9 @@ validate_pattern(struct validator *state, pattern_ty p, int star_ok)
                 }
             }
 
+            if (ret == 0) {
+                break;
+            }
             if (!validate_patterns(state, p->v.MatchClass.patterns, /*star_ok=*/0)) {
                 ret = 0;
                 break;

If we don't do this we can end up calling _PyAST_Compile with an error set.

Linked PRs
@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label May 14, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue May 14, 2023
@iritkatriel
pythongh-104482: Fix error handling bugs in ast.c
5a4e346
@iritkatriel iritkatriel mentioned this issue May 14, 2023
Merged
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 14, 2023
iritkatriel added a commit that referenced this issue May 15, 2023
@iritkatriel
gh-104482: Fix error handling bugs in ast.c (#104483)
8a3702f
iritkatriel added a commit to iritkatriel/cpython that referenced this issue May 15, 2023
@iritkatriel
[3.11] pythongh-104482: Fix error handling bugs in ast.c
6e02b76
@bedevere-bot bedevere-bot mentioned this issue May 15, 2023
Merged
iritkatriel added a commit that referenced this issue May 16, 2023
@iritkatriel
[3.11] gh-104482: Fix error handling bugs in ast.c (#104514)
52a18fe
carljm added a commit to carljm/cpython that referenced this issue May 16, 2023
@carljm
Merge branch 'main' into supermon
a6dd626 
* main:
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  pythongh-64595: Fix write file logic in Argument Clinic (python#104507)
  pythongh-104523: Inline minimal PGO rules (python#104524)
  pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)
  pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)
  pythongh-103763: Implement PEP 695 (python#103764)
  pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)
  pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)
  pythongh-104482: Fix error handling bugs in ast.c (python#104483)
  pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)
  pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-104482: Fix error handling bugs in ast.c iritkatriel/cpython
1 participant
@iritkatriel