Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated postcss parser no longer working #4071

Closed
olsonpm opened this issue Feb 28, 2018 · 2 comments
Closed

deprecated postcss parser no longer working #4071

olsonpm opened this issue Feb 28, 2018 · 2 comments
Assignees
@ikatyang
Labels
area:api Issues with Prettier's Application Programming Interface locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! type:bug Issues identifying ugly output, or a defect in the program

Comments

@olsonpm
Copy link

olsonpm commented Feb 28, 2018 •
edited
Loading

The problematic commit is dc26445

I was unable to reproduce on the playground because this is a deprecated option, thus I created a github repo with reproduction instructions.

I looked a bit at the code but was pretty lost at the intent of what all was going on in that commit. It would be helpful to have someone more familiar with the codebase take a look, though I will spend some more time myself tomorrow.

Workaround: npm i [email protected]

I noticed this issue when prettier-atom was unable to format my *.scss file - it still relies on the deprecated option.

Thanks so much again for this library
@ikatyang ikatyang added type:bug Issues identifying ugly output, or a defect in the program area:api Issues with Prettier's Application Programming Interface labels Feb 28, 2018
@ikatyang ikatyang self-assigned this Feb 28, 2018
@ikatyang ikatyang mentioned this issue Feb 28, 2018
Merged
@ikatyang ikatyang added the status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! label Feb 28, 2018
@olsonpm olsonpm mentioned this issue Feb 28, 2018
Closed
@suchipi
Copy link
Member

suchipi commented Feb 28, 2018

This fix went out in 1.11.1

@olsonpm
Copy link
Author

olsonpm commented Feb 28, 2018

Oh nice - I checked a few hours back and didn't see a release pushed to npm. This was taken care of very quickly - thanks so much 👍

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ikatyang ikatyang

Labels
area:api Issues with Prettier's Application Programming Interface locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suchipi @olsonpm @ikatyang