Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prettier/prettier
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.12.0
Choose a base ref
...
head repository: prettier/prettier
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.13.0
Choose a head ref
  • 6 commits
  • 64 files changed
  • 4 contributors

Commits on Jan 27, 2017

  1. Simplify arrow functions that use blocks (fixes #268) (#496)

    @jlongster
    jlongster authored Jan 27, 2017
    Configuration menu
    Copy the full SHA
    aaea8b1 View commit details
    Browse the repository at this point in the history

  2. Properly print comments for BinaryExpression (#494) 

    We don't call the generic print on the BinaryExpression itself, so we need to manually print those comments. It's going to be useful for my work on the MemberExpression :)
    @jlongster
    vjeux authored and jlongster committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    8f26568 View commit details
    Browse the repository at this point in the history

  3. Preserve empty line after comment (#493) 

    The logic was already working, it was just special-cased to the first comment of the file! Presumably because the new line detection logic used to be broken ;)

I manually checked the first 10 snapshots and they are all legit, so I assume that all of them are.

Fixes #356
    @jlongster
    vjeux authored and jlongster committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    956779e View commit details
    Browse the repository at this point in the history

  4. [JSX] Handle each line of text separately, allow up to one extra newl… 

    …ine (#455)

* [JSX] Treat each line of text in a paragraph as its own group

* [JSX] Allow one extra newline
    @rattrayalex @jlongster
    rattrayalex authored and jlongster committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    a9b7016 View commit details
    Browse the repository at this point in the history

  5. Proper support for dangling comments (#492) 

    * Proper support for dangling comments

In one code path, the dangling comment case is not properly handled. So I added the dangling comment, but it turns out that we only print manually in two node types: Program and BlockStatement. I made the generic printComment function print it everywhere but those two nodes. I tried to get rid of those special cases but unfortunately we need them there otherwise they are not printed at the right place.

Fixes #20

* Output dangling comments in specific places
    @jlongster
    vjeux authored and jlongster committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    32059f6 View commit details
    Browse the repository at this point in the history

  6. 0.13.0

    vjeux committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    94b137a View commit details
    Browse the repository at this point in the history
Loading