Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1 Upgrade Guide: seems as though pl.NUMERIC_DTYPES is no longer actively supported? #18062

Closed
DeflateAwning opened this issue Aug 6, 2024 · 3 comments
Closed

v1 Upgrade Guide: seems as though pl.NUMERIC_DTYPES is no longer actively supported? #18062

DeflateAwning opened this issue Aug 6, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@DeflateAwning
Copy link
Contributor

Description

It seems as though pl.NUMERIC_DTYPES (and related list constants) are no longer supported? Type hinting/linting support for them is failing, although the code itself is not yet failing it seems.

Link

https://docs.pola.rs/releases/upgrade/1/
@DeflateAwning DeflateAwning added the documentation Improvements or additions to documentation label Aug 6, 2024
@mcrumiller
Copy link
Contributor

mcrumiller commented Aug 6, 2024 •
edited
Loading

These are now located in pl.datatypes.group.NUMERIC_DTYPES. I don't believe they are re-exported anywhere so you'll have to use the full path:

from polars.datatypes.group import NUMERIC_DTYPES

@DeflateAwning
Copy link
Contributor Author

Any reason they're not re-exported anymore? Could they be aliased the same as before? Would you accept a PR?

They're super helpful methods when working with dynamic and user-supplied dataframes.

The craziest part is that, as of v1.4.1, they are still accessible by pl.NUMERIC_DTYPES; there's just no type hinting/linting support for them.

@DeflateAwning
Copy link
Contributor Author

Well I guess this is the way it is now. Closing so higher priorities can be addressed.

@DeflateAwning DeflateAwning closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcrumiller @DeflateAwning