Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overwrite operation still issued even "ndctl sanitize-dimm nmem0 --overwrite" failed #244

Open
yizhanglinux opened this issue May 9, 2023 · 2 comments
Open

overwrite operation still issued even "ndctl sanitize-dimm nmem0 --overwrite" failed #244

yizhanglinux opened this issue May 9, 2023 · 2 comments

Comments

@yizhanglinux
Copy link
Contributor

Hello
I tried ndctl sanitize-dimm nmem0 --overwrite, it tells me the execution failed, but the overwrite operation still issued to nmem0.

# uname -r
6.4.0-rc1+

# ndctl setup-passphrase "$dev" -k user:"$masterkey"
passphrase enabled for 1 nmem.
# ./ndctl list -Di
[
  {
    "dev":"nmem1",
    "id":"8089-a2-1833-00000510",
    "handle":257,
    "phys_id":32,
    "flag_failed_map":true,
    "security":"disabled"
  },
  {
    "dev":"nmem3",
    "id":"8089-a2-1833-00000497",
    "handle":4353,
    "phys_id":44,
    "security":"disabled"
  },
  {
    "dev":"nmem0",
    "id":"8089-a2-1833-000004a3",
    "handle":1,
    "phys_id":26,
    "security":"unlocked"
  },
  {
    "dev":"nmem2",
    "id":"8089-a2-1833-000004a9",
    "handle":4097,
    "phys_id":38,
    "security":"disabled"
  }
]
# ls /etc/ndctl/keys/
keys.readme  nvdimm_8089-a2-1833-000004a3_intel-purley-04.khw1.lab.eng.bos.redhat.com.blob  nvdimm-master.blob

# ./ndctl sanitize-dimm nmem0 --overwrite
libndctl: ndctl_dimm_enable: nmem0: failed to enable
overwrite issued for 0 nmem.


# ./ndctl list -Di
[
  {
    "dev":"nmem1",
    "id":"8089-a2-1833-00000510",
    "handle":257,
    "phys_id":32,
    "flag_failed_map":true,
    "security":"disabled"
  },
  {
    "dev":"nmem3",
    "id":"8089-a2-1833-00000497",
    "handle":4353,
    "phys_id":44,
    "security":"disabled"
  },
  {
    "dev":"nmem0",
    "id":"8089-a2-1833-000004a3",
    "handle":1,
    "phys_id":26,
    "state":"disabled",
    "security":"overwrite"
  },
  {
    "dev":"nmem2",
    "id":"8089-a2-1833-000004a9",
    "handle":4097,
    "phys_id":38,
    "security":"disabled"
  }
]
@yizhanglinux yizhanglinux mentioned this issue May 9, 2023
Open
@davejiang
Copy link
Collaborator

Hmm....I don't understand why it attempts to enable the dimm while attempting overwrite. Can you enable verbose debugging and provide the log please?

@davejiang
Copy link
Collaborator

Ok, I think I know why we are seeing this behavior. Overwrite has been issued, but then we call revalidate_labels() afterwards. and that fails. I think this is the wrong place to do so because overwrite is still in progress, and therefore it will fail. But it makes sense that overwrite succeeded because it's already issued before this software error. And the 0 nmem overwritten is deceiving. revalidate_labels() error does not reverse or stop the overwrite operation.

@djbw, you introduced the revalidate_labes() call for overwrite. But it's to be failing on a real dimm. I don't think you can call that until the DIMM has completed overwrite. So it may not be something that can be issued from user space since ndctl is stateless?
8186ec8 ("ndctl/dimm: Flush invalidated labels after overwrite")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davejiang @yizhanglinux