-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickinstall instructions for macOS #3130
Update quickinstall instructions for macOS #3130
Conversation
The path specified for clang++ was incorrect. The result was cmake command fails. Per this stack overflow answer (https://stackoverflow.com/a/53889826) these are the correct flags.
Did this end up working with multithreading? The homebrew version is there because if you install clang via homebrew, it will come with OpenMP support. The system clang compiler does not have openmp support. |
Yes, it works for me! |
Well if so, I think you should feel free to add a note that this is how you use the system's clang. However, the previous instructions show how to install clang via homebrew, so if the user followed the instructions above they end up not using the compiler that it used. What do you think is the best way to describe this? I think if you were to just not set the CC and CXX variables, the path you set is what gets found. Ah. And I think this relates to whether sudo was used when running homebrew, maybe. Did you use sudo? That would explain the difference if so. |
@sohhae -- can you double check that you were able to run on multiple threads with apple clang, and not just that the code ran cleanly? You can double check that you are seeing something like:
at the top when OpenMC is run (note the |
@gridley This is the clang installed by homebrew. I have confirmed this by uninstalling llvm, and verifying that the clang executable is no longer present, then reinstalling and confirming that the executable is present again. The current path specified in the documentation seems to be incorrect, @jtramm thanks for the explanation. Please see below.
|
Wow, I wonder what the difference is! Have you seen what happens if you just don't set the CC and CXX files? |
Thanks for clarifying @sohhae! On my system, homebrew installs llvm to
OR
From what I can tell in some of the secondary comments on this stack overflow post, the paths that homebrew makes binary simlinks is different depending on M1 vs. M2 or newer (for reasons unknown!). To future proof things, we might also advise the user to double check where homebrew is installing things via:
|
Thank you for getting to the bottom of this John! Yes, we should definitely just note that it may be one or the other. Hopefully we can eventually write a more detailed install guide (not on this page) noting that homebrew isn't necessarily the only route as you've noted before John. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.
The path for clang++ compiler doesn't seem to be correct. Per Stack Overflow, this seemed to work for my M2 MacBook Pro.
Fixes # (issue)
N/A
Checklist