Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding only specific integrations #70

Open
pauldowman opened this issue Oct 30, 2015 · 4 comments
Open

Allow adding only specific integrations #70

pauldowman opened this issue Oct 30, 2015 · 4 comments
Labels
enhancement

Comments

@pauldowman
Copy link
Member

It should be possible to split this into multiple packages, e.g. okgrow:analytics-google, okgrow:analytics-mixpanel, etc.

I haven't investigated but we could probably split out the integrations from analytics.js into separate packages.

Note that I've tested it and we would only save about 40k currently. Less if you use more than one integration.
@pauldowman pauldowman mentioned this issue Oct 30, 2015
Closed
@cfnelson
Copy link
Contributor

Segment.io provides seperate repo's for each integration. You can check them all out here. I think it is a good idea as it will solve all the enhancement requests. Will need to think of a good way to implement this.

Copy link

We plan to address this issue by unbundling the currently embedded customized Segment analytics.js module which will allow much greater flexibility by having users of this package install what they need from Segment’s module.” You will see this coming in version 4.0.0 of this package and version 2.0.0 of the https://github.com/okgrow/auto-analytics package in the next couple of weeks.

@ghost ghost removed the pull-request-encouraged label Jul 21, 2017
@Macbit
Copy link

Macbit commented Jul 13, 2018

@ccuilla so how does the latest version of this package function? Is analytics.js embedded or it needs to be added separately as in auto-analytics ?

Copy link

@Macbit The latest version (3.0.5) of this (the Meteor) package has a dependency on version 1.0.6 of our underlying npm package https://github.com/okgrow/auto-analytics. Version 1.0.6 of that package still includes our build of the most common Segment analytics integrations. In short you should just be able to install this package and get the whole thing.

At this point we have not updated the Meteor package to depend on version 2.x of https://github.com/okgrow/auto-analytics which removes the embedded analytics.js so you can roll your own.

I hope this helps clarify things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pauldowman @Macbit @cfnelson