Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider parenthesized expressions with JSDoc to be a form of type assertions #5158

Closed
DanielRosenwasser opened this issue Oct 7, 2015 · 3 comments
Closed

Consider parenthesized expressions with JSDoc to be a form of type assertions #5158

DanielRosenwasser opened this issue Oct 7, 2015 · 3 comments
Assignees
@weswigham @rbuckton
Labels
Domain: JSDoc Relates to JSDoc parsing and type generation Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Milestone
TypeScript 2.5

Comments

@DanielRosenwasser
Copy link
Member

To quote @weswigham on #4447 (comment):

in [the] closure compiler you do inline casts with jsdoc comments like so:

var x = /** @type {Foo.Bar} */ (y);

We should consider supporting this in Salsa.
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Salsa labels Oct 7, 2015
@weswigham
Copy link
Member

Also type assertions in the form:

/** @type {Foo.Bar} */ var x = y;

and (in constructors:)

/** @type {Foo.Bar} */
this._foo = undefined;

which I believe are also both recognized as type annotations by the closure compiler.

@mhegazy mhegazy added Suggestion An idea for TypeScript In Discussion Not yet reached consensus and removed Bug A bug in TypeScript labels Dec 8, 2015
@DanielRosenwasser DanielRosenwasser mentioned this issue Apr 9, 2016
Closed
@mhegazy mhegazy added the Domain: JSDoc Relates to JSDoc parsing and type generation label Dec 15, 2016
@mhegazy mhegazy mentioned this issue Dec 15, 2016
Open
@Jessidhia Jessidhia mentioned this issue Jan 6, 2017
Closed
@DanielRosenwasser DanielRosenwasser mentioned this issue Jun 18, 2017
Closed
@DanielRosenwasser DanielRosenwasser removed the In Discussion Not yet reached consensus label Jul 12, 2017
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 2.5 milestone Jul 12, 2017
@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Jul 12, 2017 •
edited
Loading

@rbuckton @weswigham discuss which of you would like to take this on.

This was referenced Jul 14, 2017
Closed
Merged
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Aug 4, 2017
@rbuckton rbuckton mentioned this issue Aug 5, 2017
Closed
Closed
This was referenced Jun 7, 2018
Closed
Merged
Copy link

@ikatyang fix(JavaScript): can you’ve show me where to find this sub-menu please ;)

@j-oliveras j-oliveras mentioned this issue Jun 17, 2018
Closed
4 tasks
@ahocevar ahocevar mentioned this issue Jun 18, 2018
Closed
@sarayourfriend sarayourfriend mentioned this issue May 27, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weswigham weswigham

@rbuckton rbuckton

Labels
Domain: JSDoc Relates to JSDoc parsing and type generation Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 2.5
Development

No branches or pull requests
5 participants
@DanielRosenwasser @weswigham @rbuckton @mhegazy