Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

It should be TypeError not ValueError #12

Open
GreatBahram opened this issue May 17, 2019 · 0 comments
Open

It should be TypeError not ValueError #12

GreatBahram opened this issue May 17, 2019 · 0 comments
Assignees
@mhajiloo

Comments

@GreatBahram
Copy link

persiantools/persiantools/utils.py

Line 7 in a88112b

raise ValueError("accept string type")

I think the message should be better than this, since we don't have string type in python. something like
"string must be str, not {}".format(string.__class__.__name__)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhajiloo mhajiloo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhajiloo @GreatBahram