Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butler showing conversion for 0PM as part of a user's ID #89

Open
phoutekier-issa opened this issue Jun 14, 2023 · 3 comments
Open

Butler showing conversion for 0PM as part of a user's ID #89

phoutekier-issa opened this issue Jun 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@phoutekier-issa
Copy link

Describe the bug
After a new user was added to our slack, the Timezone Butler started displaying timezone conversions anytime he was tagged even when there was no time in the actual message. I believe that the character '0PM' appear in this user's ID.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any slack channel with Timezone Butler
  2. Say '0PM'
  3. Other users will see timezone conversions for the nonsensical 0PM.

Expected behavior
No Timezone Butler conversion should occur when XPM or XAM is found in a user's ID as part of a tag

Screenshots
image

Additional context
In the screenshot, the middle welcome message is from somebody in the same time zone and me, so there was no conversion.

@phoutekier-issa phoutekier-issa added the bug Something isn't working label Jun 14, 2023
@dmk1111
Copy link

dmk1111 commented Dec 14, 2023

We've got same issue for user with id that contains 1AM

@dima-supy-io
Copy link

Any update on this one?

@mathieudutour
Copy link
Owner

Happy to merge a PR fixing this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants