Add BMBF logo #531
Add BMBF logo #531
Conversation
|
@bjrne I think we have it since the funding was approved? Is there something else to be done or can we merge this? I'll be happy to review |
|
Then do review, but before deploy we need to explicitly ask for approval of the style/positioning/size/idk. I will send them an email this week. It would be awesome to have the icon version deployed to staging for them to review. |
You mean this branch? @Baschdl can you make bjarne happy? |
| msgid "Gefördert von" | ||
| msgstr "Sponsored by" | ||
|
|
||
| msgid "<a href=\"https://www.bmbf.de/de/ueber-uns-21.html\" target=\"_blank\">" |
There was a problem hiding this comment.
I'd strip the html tag and only translate the URL.. Less error-prone?
There was a problem hiding this comment.
The idea here was that auto-format tools work correctly. Some are actually able to somewhat format html code with django tags, but stop working when tags are woven into the code to deeply. Adding elements via tags is relatively straight-forward intentation wise compared to inserting something mid-element ("Is it a tag? Does it end the element and start a new one? ...")
| </div> | ||
|
|
||
|
|
||
| <div style="background-color: #f5f5f5;"> |
There was a problem hiding this comment.
This would be a good use-case for https://caniuse.com/#feat=mdn-css_selectors_nth-child
I know it's not really pertinent to the PR but when I start having to manually move something like this I get CSS tickles :)
There was a problem hiding this comment.
Could you then add the necessary changes to this PR? This would take me way longer :)
|
I've sent a request to @andyz02 via Whapp to set up a DNS name for staging.m4h.de, when he gets around to do that, I will deploy an identical setup to the new production server on that with an empty DB and this PR deployed EDIT: Cloning the entire prod vm should get us as close a testing setup as possible. |
|
@bjrne I've setup an instance at https://staging.match4healthcare.de but I think we need to do something with the design, I'll hit up @andyz02 if he can have a look.. |
|
Two times "Sponsored by" looks a bit strange |
Closes #487
Before this goes live, we need to ask for their approval. So this should stay in Draft form until we have their reply. Reviews welcome.