Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive on constants #266

Open
dwijnand opened this issue Nov 23, 2018 · 0 comments
Open

False positive on constants #266

dwijnand opened this issue Nov 23, 2018 · 0 comments
Labels
bug

Comments

@dwijnand
Copy link
Collaborator

dwijnand commented Nov 23, 2018 •
edited
Loading

As it says in the Scala spec:

in the generated code [references to the constant value x] are replaced by the definition's right-hand side e.

(in SLS 4.1 Value Declarations and Definitions)

Therefore even if it's true that a change in the type of a constant is a change in its binary API there are no call sites in bytecode to worry about. The only breakage is in source compatibility.
@dwijnand dwijnand mentioned this issue Nov 23, 2018
Merged
@dwijnand dwijnand changed the title Falso positive on constants False positive on constants Nov 23, 2018
@dwijnand dwijnand added the bug label Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwijnand