How to write correctly generic in 2.9.9 for relations? #2072

koraga · 2024-10-16T13:03:01Z

koraga
Oct 16, 2024

For code:

final class Rate extends Model
{
    public function first(): BelongsTo
    {
        return $this->belongsTo(User::class);
    }

    /**
     * @return BelongsTo<User, Rate>
     */
    public function second(): BelongsTo
    {
        return $this->belongsTo(User::class);
    }

    /**
     * @return BelongsTo<User, $this>
     */
    public function third(): BelongsTo
    {
        return $this->belongsTo(User::class);
    }
}

i get error:

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   app/Rate/Models/Rate.php                                                                                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------- 
  13     Method App\Rate\Models\Rate::first() return type with generic class Illuminate\Database\Eloquent\Relations\BelongsTo does not specify its types:       
         TRelatedModel, TDeclaringModel                                                                                                                         
  23     Method App\Rate\Models\Rate::second() should return Illuminate\Database\Eloquent\Relations\BelongsTo<App\Admin\Models\User, App\Rate\Models\Rate> but  
         returns Illuminate\Database\Eloquent\Relations\BelongsTo<App\Admin\Models\User, $this(App\Rate\Models\Rate)>.                                          
         💡 Template type TDeclaringModel on class Illuminate\Database\Eloquent\Relations\BelongsTo is not covariant. Learn more:                               
            https://phpstan.org/blog/whats-up-with-template-covariant                                                                                           
  31     Method App\Rate\Models\Rate::third() should return Illuminate\Database\Eloquent\Relations\BelongsTo<App\Admin\Models\User, App\Rate\Models\Rate> but   
         returns Illuminate\Database\Eloquent\Relations\BelongsTo<App\Admin\Models\User, $this(App\Rate\Models\Rate)>.                                          
         💡 Template type TDeclaringModel on class Illuminate\Database\Eloquent\Relations\BelongsTo is not covariant. Learn more:                               
            https://phpstan.org/blog/whats-up-with-template-covariant                                                                                           
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------

Answered by calebdw

Oct 16, 2024

Duplicate of #2071, see 17bce5f

View full answer

calebdw · 2024-10-16T13:04:15Z

calebdw
Oct 16, 2024

Duplicate of #2071, see 17bce5f

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

How to write correctly generic in 2.9.9 for relations? #2072

{{title}}

Replies: 1 comment

{{title}}

Select a reply

How to write correctly generic in 2.9.9 for relations? #2072

koraga Oct 16, 2024

Replies: 1 comment

calebdw Oct 16, 2024

koraga
Oct 16, 2024

calebdw
Oct 16, 2024