Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--extra-config controller-manager options are ignored (masked by leader-elect) #9134

Closed
tstromberg opened this issue Aug 31, 2020 · 1 comment · Fixed by #9136
Closed

--extra-config controller-manager options are ignored (masked by leader-elect) #9134

tstromberg opened this issue Aug 31, 2020 · 1 comment · Fixed by #9136
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@tstromberg
Copy link
Contributor

We have a regression bug in our kubeadm YAML generation, seemingly caused by #8431 where we set leader-elect=false.

We end up writing two controllerManager sections to the YAML file, and only the last one wins. It's possible this broken behavior exists for other components. I was able to verify it using ./out/minikube start --extra-config=kubelet.max-pods=10 --extra-config controller-manager.kube-api-qps=5

`

apiVersion: kubeadm.k8s.io/v1beta2
kind: ClusterConfiguration
apiServer:
  certSANs: ["127.0.0.1", "localhost", "172.17.0.3"]
  extraArgs:
    enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
controllerManager:
  extraArgs:
    kube-api-qps: "5"
certificatesDir: /var/lib/minikube/certs
clusterName: mk
controlPlaneEndpoint: control-plane.minikube.internal:8443
dns:
  type: CoreDNS
etcd:
  local:
    dataDir: /var/lib/minikube/etcd
    extraArgs:
      proxy-refresh-interval: "70000"
controllerManager:
  extraArgs:
    "leader-elect": "false"

We currently set leader-elect=false by default. Unfortunately, we do so in a way that
@tstromberg tstromberg changed the title --extra-config controller-manager options are ignored --extra-config controller-manager options are ignored (masked by leader-elect) Aug 31, 2020
@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. labels Aug 31, 2020
@tstromberg
Copy link
Contributor Author

/cc @priyawadhwa

@priyawadhwa priyawadhwa mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --extra-config for scheduler/controllerManager by removing hardcoded values priyawadhwa/minikube
1 participant
@tstromberg