New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant request when limit is over 200 #436

Open

akindemirci opened this issue Nov 18, 2024 · 0 comments

akindemirci commented Nov 18, 2024 •

edited

Loading

In AbstractApi.php, the function retrieveData makes a redundant final request if the limit is defined over 200.

On line 357, the if statement to reset $limit to zero and end the while loop is currently like this:

$newDataSet['offset'] >= $newDataSet['total_count']

This way, the while loop continues for another request whose result will be definitely empty.

I think it should be like this:

$newDataSet['limit'] + $newDataSet['offset'] >= $newDataSet['total_count']

Thanks.

akindemirci changed the title ~~Redunant request when limit is over 200~~ Redundant request when limit is over 200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment