Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip publish for whitelisted files #3

Open
jvican opened this issue Jun 21, 2017 · 11 comments
Open

Skip publish for whitelisted files #3

jvican opened this issue Jun 21, 2017 · 11 comments
Labels
feature help wanted spree

Comments

@jvican
Copy link
Owner

jvican commented Jun 21, 2017

There are files in a repository, like docs, that should not affect the compilation of the project and therefore publish a new artifact (the artifact will be the same as the one previously released).

I would like sbt-release-early to allow me to define the whitelisted files in my build in the following way:

releaseEarlyWhitelistedFiles in Global := List("README.md", "CONTRIBUTING.md", ...)

When I commit this setting implementation, the releaseEarly would not trigger the publish task if only those files have been modified. If there's a change in any other file, it will publish an artifact as expected.

The implementation of this feature cannot assume that the previous commit has been released, and therefore we need to get the modified files since the last published commit (contrary to the last commit, i.e. HEAD~1).
@olafurpg
Copy link
Contributor

Could we automatically derive the whitelist as files that are not in any sources in the sbt build?

@jvican
Copy link
Owner Author

jvican commented Jun 22, 2017

Yes, we could, good point. We should also detect changes in:

  • Sbt files.
  • Managed sources.
  • Managed libraries (things in /lib).
  • Resources.

I think I'm not missing anything, but haven't devoted it too much thinking.

@jvican jvican added this to the v1.0.3 milestone Jun 22, 2017
@jvican
Copy link
Owner Author

jvican commented Sep 3, 2017

By the way, for some of the files, you can already do this with Drone by adding [CI SKIP] or [SKIP CI] to the first line of the commit message. The case that is not supported is when you want to modify a file that changes the behaviour of tests but has no relevance to the final published binaries.

@jvican jvican removed this from the v1.2.0 milestone Sep 9, 2017
@jvican jvican added the spree label Oct 6, 2017
@jvican
Copy link
Owner Author

jvican commented Oct 6, 2017

I'm adding this for an spree. Hope this will get solved in Lambda World at the end of October.

@laughedelic
Copy link
Collaborator

I'm adding this for an spree

How about adding Hacktoberfest label? 🍻 😉

@jvican
Copy link
Owner Author

jvican commented Oct 6, 2017

We call them sprees because that's the official name https://github.com/scalacenter/sprees. But we can add another label for the awesome Hacktoberfest! 😄

@laughedelic
Copy link
Collaborator

Cool! I didn't know about scalacenter/sprees (I thought it's just another word for "hackaton").

👕 More free t-shirts to the god of t-shirts! 😆

@jvican
Copy link
Owner Author

jvican commented Oct 6, 2017

Yeah, and hope we see each other in a spree soon so that I can you your well-deseved t-shirt! We usually organize them in popular Scala conferences. Next up is Lambda World, in Cadiz, at the end of the month.

@laughedelic
Copy link
Collaborator

laughedelic commented Oct 6, 2017 •
edited
Loading

Haha 😅 that's a fortunate coincidence! I'm coming to Lambda World (I live in Granada, so it's relatively close).

@jvican
Copy link
Owner Author

jvican commented Oct 6, 2017

Well, that's awesome 😄! We'll go for a beer. You can also join us at the spree, we're looking for maintainers that would propose tickets in their projects. Your sbt plugins would be a great fit for the spree if you have low-hanging fruits like this one 🎉.

@laughedelic
Copy link
Collaborator

Cool! 🍻

You can also join us at the spree, we're looking for maintainers that would propose tickets in their projects.

Sounds great 👍 I will think about it and add something to scalacenter/sprees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted spree
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laughedelic @olafurpg @jvican