Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test-coverage action to linux or windows? #174

Open
josephguillaume opened this issue Feb 2, 2021 · 1 comment
Open

Move test-coverage action to linux or windows? #174

josephguillaume opened this issue Feb 2, 2021 · 1 comment
Labels

Comments

@josephguillaume
Copy link
Collaborator

Reported by @buzacott: #160

"the test-coverage action is failing and it seems like there is some compiling error on one of the dependencies to setup the action. After a quick look it looks like it is a fortran/macOS issue, but perhaps the action should be run using linux as software compatibility will be more robust there."

* installing *source* package ‘quantreg’ ...
** package ‘quantreg’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
gfortran -mmacosx-version-min=10.13 -fno-optimize-sibling-calls  -fPIC  -Wall -g -O2  -c akj.f -o akj.o
make: gfortran: No such file or directory
make: *** [akj.o] Error 1
ERROR: compilation failed for package ‘quantreg’

I agree that moving to linux or windows might be a good option here, but not sure if there's anything else macOS specific in the github action. Fixing the gfortran setup might still be worthwhile.

@josephguillaume josephguillaume added this to the 1.0 milestone Feb 2, 2021
@buzacott
Copy link

buzacott commented Feb 2, 2021

The test-coverage action is passing now and it looks like the issue was temporary. No idea why it was failing before as gfortran should have been available because the workflow installs gcc via brew.

Either way moving to e.g. ubuntu-latest isn't a bad idea for the workflows, but perhaps not a priority.

@josephguillaume josephguillaume removed this from the 1.0 milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants