Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement for gr4j to na.trim C output #161

Open
josephguillaume opened this issue Aug 13, 2020 · 0 comments
Open

Remove requirement for gr4j to na.trim C output #161

josephguillaume opened this issue Aug 13, 2020 · 0 comments
Labels
help-wanted

Comments

@josephguillaume
Copy link
Collaborator

josephguillaume commented Aug 13, 2020 •
edited
Loading

The test for gr4j trims NAs before comparing C and R outputs.
https://github.com/josephguillaume/hydromad/blob/master/tests/testthat/test-sma-sim.R#L27

It's not clear why this is required.
We need to check whether the gr4j and gr4jrouting implementations do actually differ in how NAs are treated in outputs, and then this hardcoded exception in the tests needs to be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephguillaume