Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename debug token environment variable key #24

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

andrewheard
Copy link
Collaborator

Renamed the primary debug token environment variable key from FIRAAppCheckDebugToken to AppCheckDebugToken. This continues to support FIRAAppCheckDebugToken as a fallback.

@andrewheard andrewheard requested a review from ncooke3 September 6, 2023 21:54
Comment on lines +120 to +122
static NSString *LocalDebugToken() {
return StoredDebugToken() ?: GenerateAndStoreDebugToken();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters, but either this function's return type should be marked nullable or GenerateAndStoreDebugToken's return type should not be marked nullable. I think the intention was to do the latter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, Nick! You're right that the intention was for GenerateAndStoreDebugToken to be nonnull (since [NSUUID UUID].UUIDString will never produce nil).

@andrewheard andrewheard merged commit 4e405b8 into main Sep 7, 2023
11 checks passed
@andrewheard andrewheard deleted the ah/debug-env-var branch September 7, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants