Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshing/VolumeFromSTL : Code refactoring #12

Open
aancel opened this issue May 12, 2016 · 2 comments
Open

Meshing/VolumeFromSTL : Code refactoring #12

aancel opened this issue May 12, 2016 · 2 comments
Assignees
Labels
type:feature A function or behavior that supports a new capability.

Comments

@aancel
Copy link
Contributor

aancel commented May 12, 2016

I propose to refactor the code in VolumeFromSTL in order to improve code readability and allow @francoisdh to have a look at the code.
In the src directory:

  • Move all the applications *_main.cpp in an src/applications directory;
  • Split the volumefromstl.hpp in the include directory into as many files as there are classes.
  • Split the volumefromstl.cpp file which contains all the classes implementation into as many files as there are classes in it.
  • Create a src/libraries directory where we put all the source files that are part of the angiotk_meshing_volumefromstl library.
  • Ensure that everything builds correctly with CMake

What do you think about it ? @prudhomm @vincentchabannes @francoisdh

@vincentchabannes
Copy link
Member

@aancel very good idea!

@prudhomm prudhomm added the type:feature A function or behavior that supports a new capability. label May 31, 2017
@prudhomm
Copy link
Member

@vincentchabannes has anything been done on this ?
should it be closed or should it remain open ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature A function or behavior that supports a new capability.
Projects
None yet
Development

No branches or pull requests

3 participants