Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact protocol map specification bug #542

Open
terrelln opened this issue Mar 10, 2023 · 0 comments
Open

Compact protocol map specification bug #542

terrelln opened this issue Mar 10, 2023 · 0 comments

Comments

@terrelln
Copy link
Contributor

https://www.internalfb.com/intern/staticdocs/thrift/docs/spec/protocol/data/#map-1

It states that:

Maps contain a variable encoded length followed by the key and value types encoded in a single byte. Next comes the payload which is encoded in a similar way to the Binary protocol.

Length Key Type Value Type Key 1 Value 1 ... Key n Value n
Variable 4-bit 4-bit Variable Variable   Variable Variable

However in the implementation, the byte containing the key type & value type is not present if the length is 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant