Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve warnings (intersecting ways) #1050

Closed
cbeddow opened this issue Aug 25, 2023 · 4 comments
Closed

Cannot resolve warnings (intersecting ways) #1050

cbeddow opened this issue Aug 25, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@cbeddow
Copy link
Contributor

cbeddow commented Aug 25, 2023

Description

image

None of these warnings when I go to submit a changeset can be resolved

They all have the but to click "connect the features" and I click it and nothing happens

On the map, they all look to actually be resolved

Version

2.0.3

What browser are you seeing the problem on? What version are you running?

Chrome v115.0

The OS you're using

win

Steps to reproduce

No response

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#background=EsriWorldImageryClarity&datasets=fbRoads,msBuildings&disable_features=boundaries&map=22.64/32.71873/-117.16396&photo_overlay=mapillary

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36

@cbeddow
Copy link
Contributor Author

cbeddow commented Aug 25, 2023

Graph.js:96 Uncaught Error: Entity n9485242671 not found
at Dr.entity (Graph.js:96:13)
at almost_junction.js:195:28
at Array.forEach ()
at x (almost_junction.js:193:15)
at l (almost_junction.js:46:33)
at N (validator.js:591:22)
at Array.forEach ()
at w (validator.js:579:25)
at validator.js:693:24
at validator.js:762:32

@Bonkles
Copy link
Contributor

Bonkles commented Aug 25, 2023

@cbeddow and I sat together for a bit on a vid call and couldn't repro- but while trying to repro we mapped some sidewalks that crossed existing parking lanes/ways to get validations to crop up. The connection warnings resolved quickly.

I posit that perhaps an unrelated bug caused the UI to start acting squirrelly (sometimes when we stack trace, the UI can continue working mostly, but start behaving very strangely).

Sure enough after enabling/disabling mapilllary, then reloading the page, we were greeted with the above trace entity n9485242671 not found.

@Bonkles
Copy link
Contributor

Bonkles commented Aug 25, 2023

Opening the 2.0.3 code in the browser (with source maps) gets me to the following line in almost_junction.js:

    function findConnectableEndNodesByExtension(way) {
      let results = [];
      if (way.isClosed()) return results;

      let testNodes;
      const indices = [0, way.nodes.length - 1];
      indices.forEach(nodeIndex => {
        const nodeID = way.nodes[nodeIndex];
        const node = graph.entity(nodeID);         <-- This guy 

@bhousel bhousel added the bug Something isn't working label Aug 25, 2023
@Bonkles
Copy link
Contributor

Bonkles commented Aug 28, 2023

Okay, so the whole issue here was : we reworked/rethought the way we saved changes to the local base graph in the application storage. This meant that certain features in the base graph were NOT getting saved.

If you edited pre-existing features, refreshed, and then clicked 'restore my changes' really fast (before the OSM data could load) then it could result in this graph error occuring, which could cause undefined UI behavior.

Strongly suspect that this is the underlying cause for #1048 and #1049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants