Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Getting Available IP Reservations sends BODY in GET request #364

Open
displague opened this issue Apr 26, 2023 · 0 comments
Open

Getting Available IP Reservations sends BODY in GET request #364

displague opened this issue Apr 26, 2023 · 0 comments

Comments

@displague
Copy link
Contributor

displague commented Apr 26, 2023

https://github.com/packethost/packngo/blob/f12198a6cc4b2ec175302b6e22f32f6605defc33/ip.go#L386

The intention is for the cidr request filtering to be submitted as a query parameter. The request may be rejected as an invalid/suspicious request as coded today.

Succinctly, r should be translated to query params and the request body should be nil as it is everywhere else:

packngo $ git grep -n DoRequest.*GET.*| grep -v nil
ip.go:386:	resp, err := i.client.DoRequest("GET", apiPathQuery, r, ar)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant