Memory leaks - can't unregister combo #34
Labels
Comments
|
Thanks for catching this. This is a big bug I introduced in 2.0. Will get a fix out as soon as I have a few minutes to spend with Keypress. |
|
The fix is in the develop branch (and the docs have been updated in the gh-pages-dev branch) and I should be pushing that through to master tomorrow. The way you should be doing this is passing the object you get from the register_combo or the array from register_many method calls back into the unregister_combo and unregister_many methods (in previous versions you would pass in the same dictionary or array you passed in to the register methods). |
|
Hi, I've clone today with bower and I'm still have problems on unregister_combo when the parameter keys_or_combo is a string. Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
if
register_combohttps://github.com/dmauro/Keypress/blob/development/keypress.js#L645 creates new cobo object and pushes that object to the registered combo list, than obviously unregister_combo ( which checking combo equality by reference https://github.com/dmauro/Keypress/blob/development/keypress.js#L672) won't work.The text was updated successfully, but these errors were encountered: