Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added defaultDeploymentRepo on RepositoryVirtual #461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added defaultDeploymentRepo on RepositoryVirtual #461

wants to merge 2 commits into from

Conversation

PatriceG
Copy link

I added support to set the default deployment repo name, that we need.
It's fixing issue #460

beliaev-maksim
beliaev-maksim requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@beliaev-maksim beliaev-maksim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need tests for this

dohq_artifactory/admin.py Outdated
@@ -872,6 +872,7 @@ def __init__(
self.notes = ""
self.package_type = packageType or package_type
self.repositories = repositories or []
default_deployment_repo_name=None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not an attribute of the class

and should we have it as such?

@PatriceG
Copy link
Author

PatriceG commented Dec 12, 2024 •
edited
Loading

sorry indeed it should be
self.default_deployment_repo_name = default_deployment_repo_name

I pushed a fix.

I'm not sure I understand how to setup a test environment for your lib.

@beliaev-maksim
Copy link
Member

please provide a unittest with mocks, we use responses

@PatriceG
Copy link
Author

PatriceG commented Dec 13, 2024 •
edited
Loading

I'm not familiar with mocking in Python.
I'm not sure I understand how to setup a test environment for your lib.
I just wanted to contribute this fix in the lib (I do have a workaround by sublcassing the RepositoryVirutal class but it's not ideal).

@beliaev-maksim
Copy link
Member

these are the classic unit tests:
https://github.com/devopshq/artifactory/blob/master/docs/CONTRIBUTE.md#unit

then you can see the unit folder and add new tests similar to other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beliaev-maksim beliaev-maksim beliaev-maksim requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatriceG @beliaev-maksim