Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bpmn-io/diagram-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v15.0.0
Choose a base ref
...
head repository: bpmn-io/diagram-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v15.1.0
Choose a head ref
  • 14 commits
  • 13 files changed
  • 2 contributors

Commits on Nov 4, 2024

  1. fix(search): correctly handle duplicate entries 

    The implementation for comparing entries did not properly account for
entries that are "equal", and whenever they occur it ran into a loop.

The implementation proposed does two things:

* First we simplify the existing logic to be a two step
  filter + sort mechanism
* Second, the search comparison is simple and robust, and handles
  equality well.

This should fix the loop issues we're seeing.

Related to camunda/web-modeler#10940
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    51543e7 View commit details
    Browse the repository at this point in the history

  2. test(search): verify partial match

    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    89f1ef9 View commit details
    Browse the repository at this point in the history

  3. feat(popup-menu): integrate popup menu into search component 

    Reverts 34a65d32abc0c80cc822be13c440c61757ae6376
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0506b10 View commit details
    Browse the repository at this point in the history

  4. test(popup-menu): restore fuzzy search test

    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0cb375f View commit details
    Browse the repository at this point in the history

  5. fix(search): search with whitespace

    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d33cab3 View commit details
    Browse the repository at this point in the history

  6. feat(search): always provide tokens 

    We ensure that for every entry that is a match we _always_ provide
tokens. This ensures that a user can rely on these tokens being there,
i.e. to render the results.

Related to bpmn-io/bpmn-js#2235
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e53ecb7 View commit details
    Browse the repository at this point in the history

  7. feat(search): find search terms across all keys 

    This ensures we properly handle fuzzy results (again),
where parts of the search is matched across different
keys.

This ensures we're not overly strict in filtering things.

Related to bpmn-io/bpmn-js#2235
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0b6a26b View commit details
    Browse the repository at this point in the history

  8. test: correct search spec title

    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ad1b800 View commit details
    Browse the repository at this point in the history

  9. style: simplify

    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bacea62 View commit details
    Browse the repository at this point in the history

  10. feat(search-pad): recognize modern tokens 

    Tokens returned by `search` are now recognized by the component,
this makes conversion simpler.
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    edffcc1 View commit details
    Browse the repository at this point in the history

  11. test(popup-menu): simplify spec 

    Co-authored-by: Michał Konopski <[email protected]>
    @misiekhardcore
    nikku and misiekhardcore committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e5624e5 View commit details
    Browse the repository at this point in the history

  12. feat(search): improve types 

    `search` is now generic, items returned will match the type closure
of searchedEntries (whatever that is).
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3ab3be3 View commit details
    Browse the repository at this point in the history

  13. chore(CHANGELOG): update to v15.1.0

    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    51a65d2 View commit details
    Browse the repository at this point in the history

  14. 15.1.0

    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c5d8765 View commit details
    Browse the repository at this point in the history
Loading