-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add League of Legends installer #156
base: main
Are you sure you want to change the base?
Conversation
Nice! I can implement a way to kill the application at some point. Are there any trigger we can use for this purpose? Like, is the login in a different process/executable, so I can stop it when came alive? |
I don't think so. RiotClientServices.exe handles both login and download. After login a new process will open, but at that point, if the user did not close the launcher after downloading, the installation is broken. It is also problematic that you can log in while downloading! Taking a look at the Lutris installer, they warn you before the installation starts. I think I can do that with a script, but I really don't wanna. |
I can implement a native way to show a dialog. Looks like the only solution rn. |
Which parameters are settleable? It seems the runtime cannot be chosen from the installer, neither if gamescope is enabled. |
I've gotten league working, but I was able to walk through the install process start to finish, and the game has even been updated through the Riot Client and it still runs well. I used lutris-ge-lol-7.14-1by adding it with Protonup-qt. Here's my config: Arch: win64
|
@noey-drew Did you use the script in the PR? |
This comment was marked as off-topic.
This comment was marked as off-topic.
I wouldn't say its dead but stalled. It would require having a message dialog to warn users not to login while the first installation of the game. Also I don't know if there is other way to set some settings like the DLL overrides via Bottles config settings instead of with ENV variables |
The "no login" message is not needed now. That was necessary when the game needed the lauch helper script. |
Type of change
Whas This Tested Using a Local Repository?
Right know it still need some tweaks that I don't know how to properly make :(
Also, the installation process has a small quirk: the user MUST NOT log in while installation. After the download, the client must be closed, and, only then, you can log in.
Since the last Flatpak release (v1.15),
modify_ldt
is allowed, so League can be finally played in Flatpak. While this release (current in pre-release) is not mainstreamed, I suggest not merging this PR yet (warn somehow clear for users).I think this looks great, although the part of making sure that the user does not log in before it properly finish installing/downloading is a bit worrisome.