Parser.consume #2913
Parser.consume #2913
Conversation
| @@ -100,7 +100,7 @@ write_some( | |||
|
|
|||
| @param ec Set to indicate what error occurred, if any. | |||
|
|
|||
| @return The number of bytes written to the stream. | |||
| @return The number of bytes read from the body. | |||
There was a problem hiding this comment.
This is a breaking API change...
There was a problem hiding this comment.
Yes, and one that is overdue.
There was a problem hiding this comment.
The meaning of the return value used to be different from what it is now. We changed it because of user requests. If we change it again, then we are breaking those users.
There was a problem hiding this comment.
The meaning of the return value used to be different from what it is now. We changed it because of user requests. If we change it again, then we are breaking those users.
Wasn't that for async_read_some? #1942
There was a problem hiding this comment.
Maybe. I think you should decide if this is a good change. And if not, what else we might do (if anything).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2913 +/- ##
===========================================
- Coverage 93.09% 93.08% -0.02%
===========================================
Files 177 177
Lines 13709 13773 +64
===========================================
+ Hits 12763 12821 +58
- Misses 946 952 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I want to write a stream API for http.
I will also need a buffer to reset a previously returned buffer from a body-writer.