Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewriteImportExtensions option for TS preset does not work with .tsx files #16021

Closed
1 task done
jimmydief opened this issue Oct 6, 2023 · 1 comment · Fixed by #16022
Closed
1 task done

rewriteImportExtensions option for TS preset does not work with .tsx files #16021

jimmydief opened this issue Oct 6, 2023 · 1 comment · Fixed by #16022
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@jimmydief
Copy link
Contributor

jimmydief commented Oct 6, 2023 •
edited
Loading

💻

  • Would you like to work on this feature?

What problem are you trying to solve?

#15913 introduced a useful option for the TS preset which allows TS code authored using "moduleResolution": "NodeNext" and "allowImportingTsExtensions": true to be transpiled to JS without breaking imports. Unfortunately, this setting does not currently apply to TSX files and imports.

Describe the solution you'd like

Include .tsx files in the new behavior introduced by the flag.

Describe alternatives you've considered

Don't use "moduleResolution": "NodeNext" or "allowImportingTsExtensions": true.

Documentation, Adoption, Migration Strategy

Unclear if this would be considered a breaking change? Seems like a fix to me.
@babel-bot
Copy link
Collaborator

Hey @jimmydief! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@jimmydief jimmydief mentioned this issue Oct 6, 2023
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite .tsx extension when using rewriteImportExtensions jimmydief/babel
2 participants
@jimmydief @babel-bot