libm/newlib: remove -Wno-maybe-uninitialized #14101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there's no warning presents now. Signed-off-by: xuxingliang <[email protected]>
xiaoxiang781216
approved these changes
Oct 11, 2024
|
What's wrong with keeping the warning enabled? It may be useful in the future. |
why? it is always good to clear the warning as much as possible. |
Hi, This PR does exactly keep warning enabled, instead of suppress those warnings. |
|
let's ignore macOS ci temp break. |
Sorry, read it quickly and confused that it does the opposite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
Remove not needed warning suppression.
Since there's no warning presents now.
Impact
No impact, CI check will confirm if there's warnings.
Testing
Tested with internal CI and reports no warnings.