-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdio/va_format: move non-standard structure va_format to nuttx/streams.h #13575
Conversation
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX Requirements. Missing Information:
Recommendations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add commit messages which describe the change and why is it needed
Yes we need increase PR and git commit descriptions quality (both need to be self explanatory).. bot was created to help.. you can .. wait was there this nice copy-paste section where all sections were filled in already before @lupyuen ? :-) |
Please provide link to nuttx-apps PR as well. |
apache/nuttx-apps#2600 Done~ |
@Donny9 please fix the build error
|
Need to re-push the change to get actual apps version in the build |
…ms.h Signed-off-by: likun17 <[email protected]> Signed-off-by: dongjiuzhu1 <[email protected]>
Summary
stdio/va_format: move non-standard structure va_format to nuttx/streams.h
Impact
N/A
Testing
local compile