Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need update to input type=checkbox/radio required states #24

Closed
scottaohara opened this issue Mar 9, 2021 · 2 comments
Closed

need update to input type=checkbox/radio required states #24

scottaohara opened this issue Mar 9, 2021 · 2 comments

Comments

@scottaohara
Copy link
Contributor

scottaohara commented Mar 9, 2021

the test for input type=checkebox role=... returns the correct 4 valid roles.

however the info returned for required states is inaccurate

on a input type=checkbox the menuitemcheckbox or switch roles shouldn't require aria-checked, as they can rely on the input's default checked attribute / state.

also, if using role=button on a checkbox, there needs to be a required aria-pressed state, otherwise role=button should be flagged as an invalid role.

edit:

a similar issue exists for input type=radio with role=menuitemradio. the input's default checked attribute / state can be used rather than aria-checked, so that shouldn't throw a required state error

@scottaohara scottaohara changed the title need update to input type=checkbox required states need update to input type=checkbox/radio required states Mar 9, 2021
@gezlemon
Copy link
Contributor

gezlemon commented Mar 9, 2021

Added exceptions for menuitemcheckbox on native checkbox and menuitemradio on native radio elements

Added test for role="button" on type="checkbox" for required aria-pressed attribute

@scottaohara
Copy link
Contributor Author

confirming updated. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants