Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce EagerStringFormatting check #1139

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Apr 14, 2024

❗ This PR is on top of #1138. ❗

This is a draft PR; a bit more work (especially around tests) is required. I'm opening the PR already, as I'd like to reference it.

Suggested commit message:

Introduce `EagerStringFormatting` check (#1139)

This new check flag code that can be simplified and/or optimized by
deferring certain string formatting operations.

@Stephan202 Stephan202 added this to the 0.17.0 milestone Apr 14, 2024
@Stephan202 Stephan202 marked this pull request as draft April 14, 2024 17:41
Copy link

sonarcloud bot commented Apr 14, 2024

Copy link

  • Surviving mutants in this change: 20
  • Killed mutants in this change: 69
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.EagerStringFormatting$StringFormatExpression 13 26
🧟tech.picnic.errorprone.bugpatterns.EagerStringFormatting 7 43

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 modified the milestones: 0.17.0, 0.18.0 Jul 20, 2024
@Stephan202 Stephan202 force-pushed the sschroevers/introduce-redundant-string-escape-check branch from 1b69726 to 96c8208 Compare August 4, 2024 10:39
@Stephan202 Stephan202 force-pushed the sschroevers/eager-string-formatting-check branch from 0caa780 to 9675a51 Compare August 4, 2024 10:52
Copy link

sonarcloud bot commented Aug 4, 2024

Copy link

github-actions bot commented Aug 4, 2024

  • Surviving mutants in this change: 20
  • Killed mutants in this change: 69
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.EagerStringFormatting$StringFormatExpression 13 26
🧟tech.picnic.errorprone.bugpatterns.EagerStringFormatting 7 43

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 modified the milestones: 0.18.0, 0.19.0 Aug 11, 2024
This check aims to simplify string constants by dropping redundant
single quote escape sequences. The check is optimized for performance.

While there, update existing checks such that they do not introduce
violations of the type flagged by this new check.
@Stephan202 Stephan202 force-pushed the sschroevers/introduce-redundant-string-escape-check branch from 96c8208 to 8ee3ce8 Compare September 21, 2024 15:00
This new check flag code that can be simplified and/or optimized by
deferring certain string formatting operations.
@Stephan202 Stephan202 force-pushed the sschroevers/eager-string-formatting-check branch from 9675a51 to 459da80 Compare September 21, 2024 15:19
Copy link

sonarcloud bot commented Sep 21, 2024

Copy link

  • Surviving mutants in this change: 20
  • Killed mutants in this change: 69
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.EagerStringFormatting$StringFormatExpression 13 26
🧟tech.picnic.errorprone.bugpatterns.EagerStringFormatting 7 43

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie modified the milestones: 0.19.0, 0.20.0 Oct 23, 2024
@rickie rickie force-pushed the sschroevers/introduce-redundant-string-escape-check branch from 8ee3ce8 to 4ce0955 Compare November 12, 2024 10:11
@Stephan202 Stephan202 force-pushed the sschroevers/introduce-redundant-string-escape-check branch 2 times, most recently from 3e30dc5 to f200a92 Compare November 18, 2024 19:06
Base automatically changed from sschroevers/introduce-redundant-string-escape-check to master November 18, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants