-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVf_QUOTEDPREFIX inconsistently escapes byte values #22833
Comments
This is already quoted on recent Perl versions, because of SVf_QUOTEDPREFIX. |
@leonerd I have to admit, I'm still on |
Then, this is definitely fixed on later perls ;) Though, this said, there is something weird going on with the encoding. It appears from this casual testing, that it escapes values 0x80 to 0xBF using
Looking at the output via
(admittedly this was much easier to read on my terminal with colours). There are various literal byte values in here with values |
I believe the code responsible is |
I am looking into this. The problem is that the code currently uses isWORDCHAR_uvchar() to determine if a codepoint is printable or not even when the string is ASCII and the codepoint is > 128. It should be using isWORDCHAR_A() instead. I also noticed another minor issue that it appends elipses at the end when it should not as it is already appending the elipses in the middle. I have a patch running in test right now. |
I don't think any of the notes in the "new bug report" template on github really apply to this issue This issue is a spun off from #20165 (comment)
In addition to not repeating the package name in this warning, can we also substr the class name in cases where it contains control characters or is longer than a "reasonable" class name ("Reasonable" could come from the longest path the OS allows, for example)
It would be nice in cases where one calls a method on a string that's not a class name, especially in webby cases, like jpgs or for large json blobs:
The text was updated successfully, but these errors were encountered: