Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] plot_hierarchical_predictions_gap is not general enough #85

Closed
AzulGarza opened this issue Oct 20, 2022 · 0 comments · Fixed by #106
Closed

[BUG] plot_hierarchical_predictions_gap is not general enough #85

AzulGarza opened this issue Oct 20, 2022 · 0 comments · Fixed by #106
Assignees
@AzulGarza

Comments

@AzulGarza
Copy link
Member

The following line is not general. Not all datasets contain the unique_id "['Total']".

hierarchicalforecast/hierarchicalforecast/utils.py

Lines 246 to 248 in 0a2d6c7

if 'y' in Y_df.columns:
y_plot = Y_df[Y_df.index =="['Total']"].y.values
plt.plot(horizon_dates, y_plot, label='True')

The total unique_id could be recovered using tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzulGarza AzulGarza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] General plot_hierarchical_predictions_gap Nixtla/hierarchicalforecast
2 participants
@mergenthaler @AzulGarza