Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rules] Revised ARIA in HTML rules for img alt="" #391

Closed
scottaohara opened this issue Apr 15, 2021 · 6 comments
Closed

[Rules] Revised ARIA in HTML rules for img alt="" #391

scottaohara opened this issue Apr 15, 2021 · 6 comments
Assignees
@shunguoy
Labels
engine Issues in the accessibility-checker-engine component enhancement New feature or request est Issues awaiting research before they can be estimated priority-3 (low) Ready for QA reproducible SME Discuss with subject matter experts Standards user-reported Issues identified outside of the core team

Comments

@scottaohara
Copy link

for an img alt="" ARIA in HTML was updated to indicate role=none and role=presentation are redundant to the implicit ARIA role. These roles should be marked as invalid, or at least flagged as a warning to authors for their redundancy
@scottaohara scottaohara added the Bug Something isn't working label Apr 15, 2021
@tombrunet tombrunet added the engine Issues in the accessibility-checker-engine component label Apr 21, 2021
Copy link

Jun 1, 2021 •
edited by shunguoy
Loading

As of June 1

  • general rule description (SME & Dev)
  • testcases written (Dev)
  • rule bug (Dev)
  • message written (SME)
  • help written (SME)

@tombrunet tombrunet added enhancement New feature or request and removed Bug Something isn't working labels Jun 1, 2021
@tombrunet
Copy link
Member

If I understand this, it's asking to flag this because the role is redundant:

<img alt="" role="none" />

Redundancy doesn't cause failures since it will show up the same in the accessibility hierarchy. It's not a 'bug' to not flag it. Changing this to an 'enhancement' to consider how to warn, or if that will cause developers too much noise.

@tombrunet tombrunet changed the title Revised ARIA in HTML rules for img alt="" [Rules] Revised ARIA in HTML rules for img alt="" Dec 16, 2021
@tombrunet tombrunet added the SME Discuss with subject matter experts label Dec 16, 2021
@mbgower
Copy link
Contributor

mbgower commented Jan 7, 2022 •
edited
Loading

As a side conversation, I'd like to discuss the impact a role="none" has on the ability of screen readers to provide personalizations to end users for images.

@marcjohlic
Copy link
Member

Hey team! Please add your planning poker estimate with ZenHub @aliunwala @drjoho @mbgower @philljenkins @shunguoy @tombrunet

est Issues awaiting research before they can be estimated label Feb 25, 2022
@shunguoy shunguoy self-assigned this Apr 13, 2022
@shunguoy
Copy link
Contributor

close as fixed per #800

@ErickRenteria
Copy link
Contributor

Validated

@philljenkins philljenkins added Standards user-reported Issues identified outside of the core team labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

Labels
engine Issues in the accessibility-checker-engine component enhancement New feature or request est Issues awaiting research before they can be estimated priority-3 (low) Ready for QA reproducible SME Discuss with subject matter experts Standards user-reported Issues identified outside of the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@scottaohara @aliunwala @marcjohlic @mbgower @philljenkins @shunguoy @tombrunet @ErickRenteria